Full implementation of features for dynamic scenes into the Viser viewer. #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Little fix incoming with JSON exports. |
|
Should be good now. :) |
brentyi
reviewed
Feb 20, 2024
| @@ -902,8 +989,10 @@ def _(_) -> None: | |||
| wxyz=pose.rotation().wxyz, | |||
| # There are some floating point conversions between degrees and radians, so the fov and | |||
| # default_Fov values will not be exactly matched. | |||
| override_fov_enabled=abs(frame["fov"] - json_data.get("default_fov", 0.0)) < 1e-3, | |||
| override_fov_enabled=abs(frame["fov"] - json_data.get("default_fov", 0.0)) > 1e-3, | |||
There was a problem hiding this comment.
also thanks for fixing my bug 🎊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request finalizes the feature fix in PR #2931.
To allow working with dynamic scenes on the new Viser viewer, the Render panel now allows for setting per-keyframe timestamps along with a default time value. When rendering, it will interpolate between the times of each keyframe (similar to FOV interpolation).
Also, unlike the legacy viewer which does not support previewing the dynamic render, this PR separates the default view (using the time in the Control panel) and the preview view so that one can preview (although blurry obviously :-)) their rendered dynamic scene!
TL;DR
Demo
demo_time_render.mp4