Refactor splatfacto gaussian params with a ParameterDict #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good to me. Some suggestions: (1) test PLY exporter end-to-end to safeguard the workflow is fine. |
|
One more thing: when rebasing on top of #2945 We need to change the parameter names for splatfacto-big. |
|
This should be ready to merge, fixed all the mentioned changes and also added loading logic to make it backwards-compatible with old checkpoints. |
|
LGTM! Can we merge this? |
brentyi
approved these changes
Mar 1, 2024
LingzheZhao
added a commit
to WU-CVGL/BAD-Gaussians
that referenced
this pull request
Mar 21, 2024
Michael-Spleenlab
pushed a commit
to Michael-Spleenlab/nerfstudio
that referenced
this pull request
Apr 26, 2024
…project#2946) * refactor splatfacto with parameterdict to simplify subclassing, defining new gaussian features * stray comment * fix exp_avg key error * backwards compatibility for checkpoint * backwards comp fix --------- Co-authored-by: Matias Turkulainen <30566358+maturk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies subclassing, and simplifies some of the logic for culling/splitting.