Add 'within' function to SceneBox #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable, I guess the convention is that the maximum and minimum bounds are not included, but that is what the OrientedBox does as well. I suggest removing the test though, I think it is not necessary here. |
Michael-Spleenlab
pushed a commit
to Michael-Spleenlab/nerfstudio
that referenced
this pull request
Apr 26, 2024
Co-authored-by: Matias Turkulainen <30566358+maturk@users.noreply.github.com>
ArpegorPSGH
pushed a commit
to ArpegorPSGH/nerfstudio
that referenced
this pull request
Jun 22, 2024
Co-authored-by: Matias Turkulainen <30566358+maturk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
withinfunction to theSceneBoxclass, analogous to thewithinfunction in theOrientedBoxclass.