Make ply export property ordering backward compatible (fixes nerfstudio-project/nerfstudio#3004) #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2024 16:34
|
never mind |
akristoffersen
requested changes
Mar 18, 2024
mathijshenquet
force-pushed
the
issue-3004
branch
from
3d3b5d8
to
6980ba7
Compare
mathijshenquet
changed the title
|
@akristoffersen I addressed your comments and added some additional checks and documentation |
akristoffersen
approved these changes
Mar 20, 2024
Michael-Spleenlab
pushed a commit
to Michael-Spleenlab/nerfstudio
that referenced
this pull request
Apr 26, 2024
…io-project#3004) (nerfstudio-project#3005) * Fixes nerfstudio-project#3004 --------- Co-authored-by: Mathijs Henquet <mathijs.henquet@nlr.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3004
I could not figure a clean way to do it with the open3d library.
The ply file produced by this patch has been verified to be loadable by aras-p/UnityGaussianSplatting and antimatter15/splat