Get rid of redundant projection matrix computations in Splatfacto (needs a gsplat update) #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oseiskar
force-pushed
the
remove-gsplat-projection-matrix
branch
from
0761483
to
6c68012
Compare
kerrj
reviewed
Mar 26, 2024
nerfstudio/models/splatfacto.py
Outdated
| @@ -738,7 +714,7 @@ def get_outputs(self, camera: Cameras) -> Dict[str, Union[torch.Tensor, List]]: | |||
| 1, | |||
| quats_crop / quats_crop.norm(dim=-1, keepdim=True), | |||
| viewmat.squeeze()[:3, :], | |||
| projmat.squeeze() @ viewmat.squeeze(), | |||
| None, # Deprecated projmat | |||
There was a problem hiding this comment.
If nerfstudio-project/gsplat#149 gets merged then this needs to be updated, I think just changing the API all at once one time is better than 2 incremental changes
|
One more thing, the gsplat version should be bumped to |
Needs gsplat >= 0.1.9
oseiskar
force-pushed
the
remove-gsplat-projection-matrix
branch
from
6c68012
to
d9c2282
Compare
Done! |
This was referenced Mar 28, 2024
kerrj
approved these changes
Mar 28, 2024
Michael-Spleenlab
pushed a commit
to Michael-Spleenlab/nerfstudio
that referenced
this pull request
Apr 26, 2024
…eds a gsplat update) (nerfstudio-project#3019) Get rid of projection matrix in ProjectGaussians with gsplat >= 0.1.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires nerfstudio-project/gsplat#97