Only load+undistort splatfacto images when they're used #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-Spleenlab
pushed a commit
to Michael-Spleenlab/nerfstudio
that referenced
this pull request
Apr 26, 2024
…roject#3043) * Only load splatfacto dataset when it's used * ruff * typo fix * Fix nerfstudio-project#2817; don't undistort for `ns-viewer --viewer.max-num-display-images 0` * ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to only undistort splatfacto train/eval images when they're used. This should speed up:
ns-exportns-render: fixes Out of memory using ns-render with splatfacto for large datasets #2971ns-viewerwith--viewer.max-num-display-images 0: fixes Make viewer's loading time faster by skipping loading all images #2817 for splatfacto