Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support splatfacto training for metashape exports #3122

Merged
merged 13 commits into from
May 2, 2024

Conversation

jb-ye
Copy link
Collaborator

@jb-ye jb-ye commented May 1, 2024

test commands:

ns-process-data metashape --xml floorboard.xml --data floorboard/ --ply floorboard.ply --output-dir floorboard_nerfstudio/

@jb-ye
Copy link
Collaborator Author

jb-ye commented May 1, 2024

@simonbethke Could you try this PR and see if it works? I manually tested your dataset, and it seems fine.

@jb-ye jb-ye requested a review from brentyi May 1, 2024 21:11
@simonbethke
Copy link
Contributor

Yea, I will test it

@simonbethke
Copy link
Contributor

Okay, i tested a little bit. The happy path works!!

The unhappy paths are rather bad. Not worse than the average quality but when taking that as benchmark it will stay bad forever :D

  1. When the ply-file has not .ply extension a stacktrace is printed. As this case is handled and even has a message, it should not print the stacktrace
  2. when providing a non-existing .ply file, it takes forever, then there are some Open3D warnings and in the end, it summarizes that it imported the non-existing file which is wrong.

@simonbethke
Copy link
Contributor

I know handling unhappy paths is tideous and no fun. If you like, just ignore what I wrote about them.

@brentyi
Copy link
Collaborator

brentyi commented May 2, 2024

For the stack trace verbosity, maybe we can add ValueError to the try/except statement?

https://github.com/nerfstudio-project/nerfstudio/blob/41deed6a52a33996b34053eea58bdc54e714573f/nerfstudio/scripts/process_data.py#L531C1-L539C1

@jb-ye
Copy link
Collaborator Author

jb-ye commented May 2, 2024

For the stack trace verbosity, maybe we can add ValueError to the try/except statement?

https://github.com/nerfstudio-project/nerfstudio/blob/41deed6a52a33996b34053eea58bdc54e714573f/nerfstudio/scripts/process_data.py#L531C1-L539C1

Yes, I sent out a new revision.

Jianbo Ye and others added 2 commits May 2, 2024 00:53
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @simonbethke @jb-ye!

@jb-ye jb-ye merged commit 49f5934 into nerfstudio-project:main May 2, 2024
2 checks passed
@simonbethke
Copy link
Contributor

Thank you both for your help!

@simonbethke
Copy link
Contributor

Regarding this PR:
unfortunately there is still a gap. If I transform something in metashape, the data cannot be exported/imported to nerfstudio anymore. I think the reason for this is, that in the metashape xml, another transform appears that is not used in the nerfstudio importer. However, I already tried to get this working but I was not able to.
I have to provide sample data for that and it would be great if somebody could look into this :)

@jb-ye
Copy link
Collaborator Author

jb-ye commented May 7, 2024

@simonbethke Could you start a new issue and provide sample data there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants