Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RealityCapture csv/ply exports work! #3131

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

jb-ye
Copy link
Collaborator

@jb-ye jb-ye commented May 8, 2024

fix #3118

Changes in this PR:

  1. fix cx,cy calculation which was done wrong previously
  2. add --ply option to ns-process-data realitycapture to support splatfacto
  3. safeguard brown4 tangential2 distortion model in full data manager, since opencv's undistort doesn't support it.

@jb-ye jb-ye changed the title Make RealityCapture csv exports work! Make RealityCapture csv/ply exports work! May 8, 2024
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kerrj kerrj merged commit a4c32ad into nerfstudio-project:main May 9, 2024
2 checks passed
@shengjie-lin
Copy link

@jb-ye You mentioned "safeguard brown4 tangential2 distortion model in full data manager, since opencv's undistort doesn't support it.". However, from my testing, changing k4 would affect the behavior of cv2.undistort. And sensors like Azure Kinect does provide k4 in the API. Can you please give some explanation on this? Thank you!

@jb-ye
Copy link
Collaborator Author

jb-ye commented May 24, 2024

@shengjie-lin cv2.undistort takes k4, k5, k6 but they are used in the division model's denominator. The camera model supported by cv2.undistort is non-standard. Standard B4 model use k4 for the highest order polynomial term. In nerfstudio, we intend to support the standard Brown Tangential model, which is the case for nerfacto and other nerf models.

@shengjie-lin
Copy link

shengjie-lin commented May 24, 2024

Thanks for the explanation @jb-ye . Does this mean COLMAP or hloc tool box also estimate the distortion coefficients in a non-compatible format from what opencv expects (specifically for the k4)?
Edit: sorry, I just checked and realized hloc only estimates k1, k2, p1, p2.

@jb-ye
Copy link
Collaborator Author

jb-ye commented May 24, 2024

@shengjie-lin I am not sure about COLMAP, it support several cameras models. The FULL_OPENCV might be something you are looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current Reality Capture Nerfstudio Import process producing very bad quality for Splatfacto.
3 participants