Fixing splat masking and double distortion #3156
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for aria, there is a runtime error when boolean masks are fed into
splatfacto
:Additionally, when the distortion parameters are all 0 (meaning there is no distortion in the image), splatfacto will still try to distort the image because
distortion_params
are not None, so adding a quick check on that prevents images from being fed to the undistort function when there is no distortion.