Small fix when evaluating splatfacto model, running ns-eval #3219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
_get_background_color()
function in splatfacto.py,self.background_color
is allocated on the cpu, when callingget_outputs()
, we get a runtime error "RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!". Added a.to(self.device)
to ensure this doesn't happen