Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize requests to the ATECC508A #17

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Serialize requests to the ATECC508A #17

merged 3 commits into from
Feb 7, 2019

Conversation

fhunleth
Copy link
Contributor

@fhunleth fhunleth commented Feb 5, 2019

No description provided.

mobileoverlord
mobileoverlord approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@mobileoverlord mobileoverlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just curious, is it problematic if two devices open the same i2c bus and talk to different devices or is it only if multiple processes try to talk to the same device?

@fhunleth
Copy link
Contributor Author

fhunleth commented Feb 6, 2019

Two devices on the same bus works. Linux will serialize the I2C commands on the bus.

@fhunleth fhunleth mentioned this pull request Feb 6, 2019
Merged
@fhunleth
Fix Markdown lint warning
d287770
@fhunleth
Serialize I2C requests to the same device
3fcd231 
This prevents multiple processes that are using the ATECC508A from
stepping on each other. The symptoms are usually that one process
crashes since the wakeup message will timeout if the chip is busy.

This commit refactors the I2C transport to start a named GenServer for
each unique ATECC508A. Requests are serialized through that GenServer.
The GenServer is supervised in the ATECC508A's supervision tree.
@fhunleth
Sync CircleCI config; test under Elixir 1.8
8646399
@fhunleth fhunleth merged commit 0eb9477 into master Feb 7, 2019
@fhunleth fhunleth deleted the funnel branch February 7, 2019 14:51
@fhunleth fhunleth mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mobileoverlord mobileoverlord mobileoverlord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fhunleth @mobileoverlord