Retry waking up ATECC on unexpected response #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code had intentions of retrying the wake up processor, but it never used it. I.e., the default number of retries was 1. This changes the default to 4 and adds a 500 ms wait in between tries. The logic for this is that wakeup errors can happen for many reasons especially since it's possible for other programs to access to ATECC simultaneously. This is definitely a problem with OpenSSL engines since they're independent of this library. The strategy for this library is to minimize calls to the ATECC via caching of responses to read-only data, but it still happens and retries are needed. 4 retries separated by 500 ms was picked since 1. it's still well under the 5 second default Erlang timer on calls, so function calls shouldn't time out, and 2. 500 ms is longer than most ATECC ops, so there's a good change that whatever conflicted is done.
mobileoverlord
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code had intentions of retrying the wake up processor, but
it never used it. I.e., the default number of retries was 1. This
changes the default to 4 and adds a 500 ms wait in between tries.
The logic for this is that wakeup errors can happen for many reasons
especially since it's possible for other programs to access to ATECC
simultaneously. This is definitely a problem with OpenSSL engines since
they're independent of this library. The strategy for this library is to
minimize calls to the ATECC via caching of responses to read-only data,
but it still happens and retries are needed.
4 retries separated by 500 ms was picked since 1. it's still well under
the 5 second default Erlang timer on calls, so function calls shouldn't
time out, and 2. 500 ms is longer than most ATECC ops, so there's a good
change that whatever conflicted is done.