Add retry mechanism that handles the watchdog_about_to_expire error #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorRigby
force-pushed
the
cjr-watchdog-expire-retry
branch
2 times, most recently
from
ebe4f36
to
0eb464f
Compare
fhunleth
reviewed
Oct 20, 2023
lib/atecc508a/request.ex
Outdated
| ) :: {:ok, binary()} | {:error, atom()} | ||
| defp transport_request(transport, payload, timeout, response_payload_len, retry \\ 1000) do | ||
| now = System.monotonic_time(:second) | ||
| retry_request_with_timeout(transport, payload, timeout, response_payload_len, now, retry) |
There was a problem hiding this comment.
Suggested change
| retry_request_with_timeout(transport, payload, timeout, response_payload_len, now, retry) | |
| retry_request_with_timeout(transport, payload, give_up_time, response_payload_len) |
| {:ok, @test_data_32} | ||
| end) | ||
|
|
||
| assert Request.read_zone(@mock_transport, :config, 0, 32) == {:ok, @test_data_32} |
There was a problem hiding this comment.
Nice! Thanks for adding a test!
ConnorRigby
force-pushed
the
cjr-watchdog-expire-retry
branch
from
0eb464f
to
85eeadb
Compare
fhunleth
reviewed
Oct 23, 2023
fhunleth
reviewed
Oct 23, 2023
ConnorRigby
force-pushed
the
cjr-watchdog-expire-retry
branch
3 times, most recently
from
e835ac0
to
4af604b
Compare
Signed-off-by: Connor Rigby <connorr@hey.com>
ConnorRigby
force-pushed
the
cjr-watchdog-expire-retry
branch
from
4af604b
to
9478634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a retry mechanism that will try for up to one second by default to retry any transaction that return
{:error, :watchdog_about_to_expire}