This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Only support signing certificate requests and call cfssl directly #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobileoverlord
force-pushed
the
csr-only
branch
from
a89f669
to
93edebf
Compare
mobileoverlord
force-pushed
the
csr-only
branch
from
93edebf
to
c4bd3e4
Compare
fhunleth
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
I'm approving this in principle since I think this is the right approach. How are we making sure that the CN is set how we want it to be? It is that nerves_hub_ca only responds to requests from nerves_hub_web and we trust nerves_hub_web to make good requests?
|
Yes, currently |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following
cfssl serveto bring upcfsslweb servers to handle requests. Callcfssldirectly.