Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to :bandit! #1226

Merged
merged 3 commits into from Feb 21, 2024
Merged

Back to :bandit! #1226

merged 3 commits into from Feb 21, 2024

Conversation

jjcarstens
Copy link
Collaborator

@jjcarstens jjcarstens commented Feb 21, 2024

This brings Bandit up-to-date and also bumps ThousandIsland with the fix to remove SO_LINGER option to prevent hangs and long run queues on larger instances with lots of device socket connections.

This is believed to resolve the issue reported in #1212 after running the same tests with these changes in the environment it was discovered in

See also ThousandIsland 1.3.3 CHANGELOG

Thanks @oestrich, @mtrudel, @joshk & @pojiro ! 馃挓 馃帀

This brings Bandit up-to-date and also bumps ThousandIsland with the fix to
remove `SO_LINGER` option to prevent hangs and long run queues on larger
instances with lots of device socket connections.

This is  believed to resolve the issue reported in #1212 after running the
same tests with these changes in the environment it was discovered in
We increment the RateLimit when accepting the SSL handshake in `DeviceSSLTransport`
so there is no need to increment here again
Copy link
Collaborator

@oestrich oestrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjcarstens jjcarstens merged commit 93c91f5 into main Feb 21, 2024
2 checks passed
@jjcarstens jjcarstens deleted the bandit-experiments branch February 21, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants