Move devices under products #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobileoverlord
force-pushed
the
product-device
branch
from
34603e2
to
957b15d
Compare
mobileoverlord
force-pushed
the
product-device
branch
from
957b15d
to
97c00ea
Compare
Merged
jjcarstens
approved these changes
Jun 21, 2019
| |> Presence.list() | ||
| |> Map.get("#{device_id}", default) | ||
| |> merge_metas |
There was a problem hiding this comment.
I don’t think you need this merge_metas because the Presence.list/1 above will call fetch, which does the meta merging
ConnorRigby
added a commit
to FarmBot/Farmbot-Web-App
that referenced
this pull request
Jun 21, 2019
* This addresses the upcoming change to the NervesHub API * nerves-hub/nerves_hub_web#499 * Update nerves_hub tests
ConnorRigby
added a commit
to FarmBot/Farmbot-Web-App
that referenced
this pull request
Jun 21, 2019
* This addresses the upcoming change to the NervesHub API * nerves-hub/nerves_hub_web#499 * Update nerves_hub tests
ConnorRigby
approved these changes
Jun 21, 2019
fhunleth
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the massive PR, but I'm unsure of how to make this change any smaller.
This PR does the following
productassociation todeviceThe biggest impact that this has is that the api routes would change and require changes to
nerves_hub_user_apiDevice management endpoints moved from
to