Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI overhaul with better cache keys and act support #38

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Conversation

doughsay
Copy link
Member

@doughsay doughsay commented Jul 29, 2020

Multiple changes to the CI script:

  • CI can now run locally using act. Caching doesn't work locally (also, one of the cache keys can't be generated locally, see here: hashFiles documentation says you can supply multiple paths, but act doesn't let you nektos/act#324).
  • Elixir and OTP versions DRYed into variables.
  • Cache keys include Elixir and OTP versions, to help invalidate stale caches when versions change
  • Dialyzer PLTs have been moved into _build and are cached alongside it.
  • The steps have been refactored to all be identical between jobs except the one or two steps that are relevant to that job. This prepares us for "composite actions", which is an upcoming feature from github. This will drastically DRY up the CI script.
  • The codecov token has been removed, they now support actions officially

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files          13       13           
  Lines         153      153           
=======================================
  Hits          145      145           
  Misses          8        8           
Impacted Files Coverage Δ
lib/afk/keycode/transparent.ex 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516ab89...bc80674. Read the comment docs.

@doughsay doughsay merged commit 629ee4b into master Jul 30, 2020
@doughsay doughsay deleted the ci-overhaul branch July 30, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant