Rename hardware target #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amclain
commented
Apr 12, 2020
| @@ -56,7 +56,7 @@ defmodule Xebow.MixProject do | |||
|
|
|||
| # Dependencies for specific targets | |||
| {:xebow_rpi0, | |||
| github: "doughsay/xebow_rpi0", ref: "v1.10.2+xebow.2", runtime: false, targets: :xebow_rpi0} | |||
| github: "doughsay/xebow_rpi0", ref: "v1.10.2+xebow.2", runtime: false, targets: :keybow} | |||
There was a problem hiding this comment.
@doughsay I recommend prefixing the Nerves system repo with nerves_system_ to follow the convention that the other Nerves targets do, if you think that's a good idea.
There was a problem hiding this comment.
You're definitely right, this makes much more sense. I should rename the system repo to be nerves_system_kebow too.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about renaming the hardware target to:
keybowrpi0My thought behind this is that the Nerves target is the hardware that the firmware is designed to run on. Since Xebow is a firmware modification to the Keybow and does not modify the hardware, I think the target should be named after the hardware.
That being said, there are two major components that could be considered in regards to Xebow's target:
Due to this I lean towards
keybowas the target, but I could see either being valid. One litmus test could be: "Can Xebow run effectively on a Raspberry Pi without the Keybow perpherials"? I believe the answer is no, which again, draws me more towardskeybowrather thanrpi0.Thoughts?