Extract PropertyTable to its own library

*Backwards incompatible - please read*

PropertyTable is now its own library and it has been simplified. While
some API affecting changes to PropertyTable were made in the library to
fix bugs, improve performance and make it more generic, this preserves
the PropertyTable semantics as much as possible to avoid application
code needing to change. I don't believe any user code should need to
change.

The backwards incompatible part of this change is that all references to
`VintageNet.PropertyTable` need to be changed to `PropertyTable`. This
shouldn't affect most code, but does affect `vintage_net_wifi`.

This fixes #352.

lib/vintage_net.ex

@@ -17,7 +17,7 @@ defmodule VintageNet do
   [github.com/nerves-networking/vintage_net](https://github.com/nerves-networking/vintage_net)
   for more information.
   """
-  alias VintageNet.{Info, Interface, PropertyTable}
+  alias VintageNet.{Info, Interface}
 
   @typedoc """
   A name for the network interface
@@ -244,11 +244,9 @@ defmodule VintageNet do
   Patterns are list of strings that optionally specify `:_` at
   a position in the list to match any value.
   """
-  @spec match(PropertyTable.property_with_wildcards()) :: [
-          {PropertyTable.property(), PropertyTable.value()}
-        ]
+  @spec match(PropertyTable.pattern()) :: [{PropertyTable.property(), PropertyTable.value()}]
   def match(pattern) do
-    PropertyTable.match(VintageNet, pattern)
+    PropertyTable.match(VintageNet, pattern ++ [:"$"]) |> Enum.sort()
   end
 
   @doc """
@@ -260,8 +258,8 @@ defmodule VintageNet do
   @spec get_by_prefix(PropertyTable.property()) :: [
           {PropertyTable.property(), PropertyTable.value()}
         ]
-  def get_by_prefix(prefix) do
-    PropertyTable.get_by_prefix(VintageNet, prefix)
+  def get_by_prefix(pattern) do
+    PropertyTable.match(VintageNet, pattern) |> Enum.sort()
   end
 
   @doc """
@@ -287,15 +285,15 @@ defmodule VintageNet do
   VintageNet.subscribe(["interface", :_, "addresses"])
   ```
   """
-  @spec subscribe(PropertyTable.property_with_wildcards()) :: :ok
+  @spec subscribe(PropertyTable.pattern()) :: :ok
   def subscribe(name) do
     PropertyTable.subscribe(VintageNet, name)
   end
 
   @doc """
   Stop subscribing to property change messages
   """
-  @spec unsubscribe(PropertyTable.property_with_wildcards()) :: :ok
+  @spec unsubscribe(PropertyTable.pattern()) :: :ok
   def unsubscribe(name) do
     PropertyTable.unsubscribe(VintageNet, name)
   end

lib/vintage_net/application.ex

@@ -17,7 +17,7 @@ defmodule VintageNet.Application do
     properties = load_initial_configurations() |> Enum.map(&config_to_property/1)
 
     children = [
-      {VintageNet.PropertyTable, properties: properties, name: VintageNet},
+      {PropertyTable, properties: properties, name: VintageNet, tuple_events: true},
       {VintageNet.PredictableInterfaceName, hw_path_ifnames},
       VintageNet.PowerManager.Supervisor,
       {BEAMNotify,

lib/vintage_net/info.ex

@@ -165,7 +165,7 @@ defmodule VintageNet.Info do
   defp sanitize_configuration(data), do: data
 
   defp format_if_attribute(ifname, name, print_name, print_since? \\ false) do
-    case VintageNet.PropertyTable.fetch_with_timestamp(VintageNet, ["interface", ifname, name]) do
+    case PropertyTable.fetch_with_timestamp(VintageNet, ["interface", ifname, name]) do
       {:ok, value, timestamp} ->
         [
           "  ",

lib/vintage_net/interface.ex

@@ -11,7 +11,7 @@ defmodule VintageNet.Interface do
   use GenStateMachine
 
   alias VintageNet.Interface.{CommandRunner, RawConfig}
-  alias VintageNet.{Persistence, PredictableInterfaceName, PropertyTable, RouteManager}
+  alias VintageNet.{Persistence, PredictableInterfaceName, RouteManager}
   alias VintageNet.PowerManager.PMControl
   alias VintageNet.Technology.Null
 
@@ -110,7 +110,7 @@ defmodule VintageNet.Interface do
          normalized_config = raw_config.source_config,
          :changed <- configuration_changed(ifname, normalized_config),
          :ok <- persist_configuration(ifname, normalized_config, options),
-         PropertyTable.put(VintageNet, ["interface", ifname, "config"], normalized_config),
+         :ok = PropertyTable.put(VintageNet, ["interface", ifname, "config"], normalized_config),
          {:error, :already_started} <- maybe_start_interface(ifname) do
       GenStateMachine.call(via_name(raw_config.ifname), {:configure, raw_config})
     end
@@ -223,7 +223,10 @@ defmodule VintageNet.Interface do
       nil ->
         # No configuration, so use a null config and fix the property table
         raw_config = null_raw_config(ifname)
-        PropertyTable.put(VintageNet, ["interface", ifname, "config"], raw_config.source_config)
+
+        :ok =
+          PropertyTable.put(VintageNet, ["interface", ifname, "config"], raw_config.source_config)
+
         raw_config
 
       config ->
@@ -731,8 +734,8 @@ defmodule VintageNet.Interface do
     ifname = data.ifname
     config = data.config
 
-    PropertyTable.put(VintageNet, ["interface", ifname, "type"], config.type)
-    PropertyTable.put(VintageNet, ["interface", ifname, "state"], state)
+    :ok = PropertyTable.put(VintageNet, ["interface", ifname, "type"], config.type)
+    :ok = PropertyTable.put(VintageNet, ["interface", ifname, "state"], state)
 
     if state != :configured do
       # Once a state is `:configured`, then the configuration provides the connection

lib/vintage_net/interface/udhcpd.ex

@@ -8,7 +8,7 @@ defmodule VintageNet.Interface.Udhcpd do
   def lease_update(ifname, lease_file) do
     case parse_leases(lease_file) do
       {:ok, leases} ->
-        VintageNet.PropertyTable.put(
+        PropertyTable.put(
           VintageNet,
           ["interface", ifname, "dhcpd", "leases"],
           leases
@@ -17,7 +17,7 @@ defmodule VintageNet.Interface.Udhcpd do
       {:error, _} ->
         Logger.error("#{ifname}: Failed to handle lease update from #{lease_file}")
 
-        VintageNet.PropertyTable.clear_prefix(VintageNet, ["interface", ifname, "dhcpd", "leases"])
+        PropertyTable.clear_all(VintageNet, ["interface", ifname, "dhcpd", "leases"])
     end
   end
 

lib/vintage_net/interfaces_monitor/info.ex

@@ -1,7 +1,7 @@
 defmodule VintageNet.InterfacesMonitor.Info do
   @moduledoc false
 
-  alias VintageNet.{IP, PropertyTable}
+  alias VintageNet.IP
 
   @link_if_properties [:lower_up, :mac_address]
   @address_if_properties [:addresses]
@@ -151,8 +151,8 @@ defmodule VintageNet.InterfacesMonitor.Info do
   """
   @spec update_present(t()) :: t()
   def update_present(%__MODULE__{ifname: ifname} = info) do
-    PropertyTable.put(VintageNet, ["interface", ifname, "present"], true)
-    PropertyTable.put(VintageNet, ["interface", ifname, "hw_path"], info.hw_path)
+    :ok = PropertyTable.put(VintageNet, ["interface", ifname, "present"], true)
+    :ok = PropertyTable.put(VintageNet, ["interface", ifname, "hw_path"], info.hw_path)
     info
   end
 
@@ -173,7 +173,7 @@ defmodule VintageNet.InterfacesMonitor.Info do
   end
 
   defp update_link_property(ifname, property, value) do
-    PropertyTable.put(VintageNet, ["interface", ifname, to_string(property)], value)
+    :ok = PropertyTable.put(VintageNet, ["interface", ifname, to_string(property)], value)
   end
 
   @doc """
@@ -182,7 +182,7 @@ defmodule VintageNet.InterfacesMonitor.Info do
   @spec update_address_properties(t()) :: t()
   def update_address_properties(%__MODULE__{ifname: ifname, addresses: address_reports} = info) do
     addresses = address_reports_to_property(address_reports)
-    PropertyTable.put(VintageNet, ["interface", ifname, "addresses"], addresses)
+    :ok = PropertyTable.put(VintageNet, ["interface", ifname, "addresses"], addresses)
     info
   end