Split resolv.conf generation for better testing #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorRigby
approved these changes
Feb 15, 2020
This pulls the pure part of creating resolv.conf contents into its own module. This allows for easier testing of future additions that will involve more complicated manipulations of the file. A side effect of this was to fix some sloppiness around IP address handling. This isn't a big deal now, but it should make IPv6 support easier to handle later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the pure part of creating resolv.conf contents into its own
module. This allows for easier testing of future additions that will
involve more complicated manipulations of the file.
A side effect of this was to fix some sloppiness around IP address
handling. This isn't a big deal now, but it should make IPv6 support
easier to handle later.