Lack of IPv4 doesn't mean disconnected #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Internet connectivity checker would declare that the network was disconnected if an IPv4 address wasn't available. This is untrue for a couple reasons: 1. IPv6 addresses are available 2. DHCP and layer 2 protocols could still be used This also had a weird side effect where interfaces would initially come up (`lan` connectivity), then go disconnected when an IPv4 address wasn't found, and then come back when an IPv4 address was found. Fixes #268
mattludwigs
approved these changes
Apr 6, 2021
ConnorRigby
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Internet connectivity checker would declare that the network was
disconnected if an IPv4 address wasn't available. This is untrue for a
couple reasons:
This also had a weird side effect where interfaces would initially come
up (
lanconnectivity), then go disconnected when an IPv4 addresswasn't found, and then come back when an IPv4 address was found.
Fixes #268