Add docs and tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ConnorRigby When I was documenting the IPv4 config helper, I noticed that setting the default gateway won't work. The default gateway needs to be set on the RouteManager so that it can handle prioritizing it against other interfaces. I'm going to add this as an issue, but wanted to make you aware in case you were wondering why the Internet wasn't working... |
mattludwigs
reviewed
May 14, 2019
| * `:broadcast` - IPv4 broadcast address as a string | ||
| * `:metric` - Route metric (TODO: THIS WON'T WORK) | ||
| * `:gateway` - Default gateway (TODO: THIS WON'T WORK) | ||
| * `:pointopoint` - ? |
There was a problem hiding this comment.
Are you looking for information here about what this is? If so, is this helpful?
http://manpages.ubuntu.com/manpages/trusty/man5/interfaces.5.html
pointopoint address
Address of other end point (dotted quad). Note the spelling of "point-to".
There was a problem hiding this comment.
Yeah, I was lazy. I wonder if that works...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds docs for the IPv4 config helper. The CommandRunner module is also tested now. It was partially tested indirectly via InterfaceTest.