Internet connectivity checker: remove unfixable transition #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a "ping" returned that there wasn't a network interface to ping, this would lead to the interface being marked disconnected with no way of escaping if it was a transient error. The original assumption was that if ping return this that it was just a matter of time before the interface went down. However, if there's a transient or unfortunate ordering of events and this happened, then the checker would stop polling and the interface could never be marked as internet-connected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a "ping" returned that there wasn't a network interface to ping, this
would lead to the interface being marked disconnected with no way of
escaping if it was a transient error.
The original assumption was that if ping return this that it was just a
matter of time before the interface went down. However, if there's a
transient or unfortunate ordering of events and this happened, then the
checker would stop polling and the interface could never be marked as
internet-connected.