Simplify if prioritization and add :route_metric_fun option #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's used so many places and makes more sense here now.
Currently, interface naming utilities and prioritization are mixed in the same module. Interface prioritization is going to get more complicate, so separating out unrelated code seems like it should make it more easy to understand.
This add docs and sets up the possibility of completely overriding route metric prioritization. Going through the default calculation is nontrivial due to a lack of information. It's way easier to just replace the whole function with exactly what you want and that's the goal here. As a result, the ability to dynamically set interface prioritization order goes away. That's nice sense it deletes a bit of code that probably wasn't used and was too inflexible anyway. This is a backwards incompatible change for anyone setting an interface prioritization table. If you don't use that, then this PR just moves code around.
This adds a new key, `:route_metric_fun`, that let's users get rid of the default metric calculator and use their own. The default calculator probably works for most users, but once you find yourself outside of what works with the defaults, it's probably easiest to code a solution that exactly works with your setup rather than try to encourage the default calculator to work for you.
fhunleth
force-pushed
the
classification-weights
branch
from
66fea81
to
1af5bd9
Compare
mattludwigs
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits mostly moves code and types around to clean up the route
metric calculation logic. Luckily, there's high test coverage here as almost all
of this is side effect free logic. Plus some code got to be deleted.
The main new feature is to add a key,
:route_metric_funthat lets youcompletely replace the built-in metric calculation that's now in the
default_metric.exmodule. The previous intention was to let users specify aprioritization list or set weights. That was never completely implemented, and
with the benefit of hindsight, looks complicated compared to implementing the
code yourself. A non-general purpose implementation is probably as simple as
pattern matching the interface name and internet status and then returning a
metric number.
This is backwards incompatible since prioritization table customization has been
deleted. I don't know anyone using this, but if they are, I hope that the new
:route_metric_funoption is a simpler solution to what they're trying toaccomplish.