Add git pre-commit hook #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattludwigs
approved these changes
Oct 3, 2021
|
I'm not 100% sure how I feel about pre-commit hooks and committing the scripts to repos. I "think" this help me more than others since you have to opt in to use the hook, and I wouldn't expect most people to opt into pre-commit hooks unless they were contributing a lot to this project. |
mattludwigs
reviewed
Oct 4, 2021
| # git pre-commit hook | ||
| # | ||
| # Install by: | ||
| # $ ln -s ../../pre-commit.sh .git/hooks/pre-commit |
There was a problem hiding this comment.
Should this be ln -s pre-commit.sh .git/hooks/pre-commit?
There was a problem hiding this comment.
The ../.. is to go back from .git/hooks to get to the base directory.
ConnorRigby
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.