Sort local routes first so that they're created before default routes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhunleth
force-pushed
the
sort-local-first
branch
from
44fb5b8
to
886a376
Compare
Local routes are needed when setting default routes. Otherwise Linux returns that the default route isn't reachable and fails the route.
There's an expectation that the route sets succeed so verify that. This only warns when clearing routes fails, though. I am unsure whether Linux automatically prunes routes when they're impossible. It seems harsh to crash if a route that we want to clear doesn't exist.
fhunleth
force-pushed
the
sort-local-first
branch
from
886a376
to
ba7aabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where default route creation failed. The order is now:
Deletions warn if they don't delete anything. I haven't seen this yet, but suspect that it might happen. Creates crash if they don't create. That would be unexpected.