Various small fixes #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 seconds was too short to wait for WiFi to connect. Bump the timeout to 60 seconds since that seems safe right now based on watching wpa_supplicant.
This lets vintage_net technologies only have to deal with a single way of specifying a configuration. Currently this is helpful when fixing WPA2 passphrases that were passed in the psk field. In the future, it will be helpful when migrating old ways of specifying configurations.
This was getting lost in the info messages. It seems more important. No action is taken to erase or move the file out of the way, so the warning will get printed every init.
This was broken when the `:local_route` tuple was updated to include the routing table.
The router was incorrectly calling "ip" with them. This also tightens up many function calls leading up to the incorrect behavior to try to catch it earlier. It also adds a test.
This removes stale and unset values from having to be handled by users.
This also simplifies the connectivity code slightly and moves some initialization out of `init/1` just in case it crashes.
This is needed to recover from GenServer crashes inside `vintage_net`. When that happens, the state of the interface isn't known. Rather than trying to figure anything out, just tear it all down and restart. The exit status is ignored from `ifdown`.
RouteManager isn't supposed to crash, but if it does, it resets the routing tables to a clean slate so all interfaces need to reconfigure themselves to get the state back.
ConnorRigby
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easiest to review the commits individually since they're each pretty small. I'll definitely split if any prove controversial.
At a high level, this fixes a few blatant bugs and fixes a supervision issue where
RouteManagerandInterfacecrashes were not recoverable. The fundamental issues were 1) incorrect supervision strategy (now:rest_for_one) and 2)ifdownalways needs to be tried to preventifupfrom exiting without doing anything.