Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing all flags in scan_results for WPA2/WPA3-Personal #52

Closed
jsimmonds2 opened this issue May 24, 2021 · 4 comments · Fixed by #53
Closed

Parsing all flags in scan_results for WPA2/WPA3-Personal #52

jsimmonds2 opened this issue May 24, 2021 · 4 comments · Fixed by #53
Assignees

Comments

@jsimmonds2
Copy link

Newer Wi-Fi routers implement WPA3 and can offer stations a mixed WPA2/WPA3-Personal security choice.

VintageNet WiFi fails to report the presence of WPA2 security in this case.

On the recent Buildroot Linux used by FarmBot Inc. on Raspberry Pi 3 Model B this scan result shows the flags as decoded by wpa_supplicant for such a router configuration, but VintageNet only reports WPS and ESS bits.

iex(farmbot@farmbot-84e5.local)18> cmd 'wpa_cli -i wlan0 -p /tmp/vintage_net/wpa_supplicant scan_results'
bssid / frequency / signal level / flags / ssid
3c:7c:3f:40:ae:f1       2442    -11     [WPA2-PSK+SAE-CCMP][WPS][ESS]   IoT
f0:2f:74:28:b6:01       2442    -31     [WPA2-PSK+SAE-CCMP][WPS][ESS]   IoT
f0:2f:74:28:6b:70       2442    -34     [WPA2-PSK+SAE-CCMP][WPS][ESS]   IoT
5c:a5:bc:9a:da:a5       2412    -40     [WPA2-PSK-CCMP][ESS]    IoT-1
[ . . . ]

This defect resulted in this discussion over in the FarmBot Forum :)

@fhunleth
Copy link
Member

Thanks for posting this.

Were you or someone else from FarmBot planning to send a PR?

@ConnorRigby
Copy link
Member

Looks like we're missing a line here https://github.com/nerves-networking/vintage_net_wifi/blob/main/lib/vintage_net_wifi/wpa_supplicant_decoder.ex#L257
i'm updating right now.

@fhunleth
Copy link
Member

PR #53 fixes this specific issue, but it doesn't fix connections to pure WPA3 and WPA2/3 access points. I think the change at bac1209 is really close, but I haven't been able to test. I should get another try tomorrow. My plan is to merge this PR after confirming that WPA3 network connections work.

@fhunleth
Copy link
Member

Update: I merged #53. WPA3 still isn't working, but I'm getting errors that look like device driver ones and the changes in #53 are needed no matter what.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants