Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Elixir ~> 1.7 #316

Merged
merged 4 commits into from
Aug 20, 2018
Merged

Add support for Elixir ~> 1.7 #316

merged 4 commits into from
Aug 20, 2018

Conversation

mobileoverlord
Copy link
Contributor

Adds support for distillery 2.x. This requires slight modifications to the Mix project.

Depends on nerves-project/shoehorn#12

@ConnorRigby
Copy link
Member

I'll check this out in a bit but i want to express my excitement first

ConnorRigby
ConnorRigby reviewed Aug 16, 2018
View reviewed changes
Copy link
Member

@ConnorRigby ConnorRigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When following the guide provided, i was left with a dependency error that i believe will be fixed when officially released. Basically my
custom nerves_system required nerves 1.2, and my mixfile wanted this version.

CHANGELOG.md
To this:

```
release :my_app do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be :test_app?

docs/Updating Projects.md
To this:

```
release :my_app do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. test_app?

@mobileoverlord
Copy link
Contributor Author

Oh right, I was converting :test_app to :my_app. I think its more readable with :my_app

This was referenced Aug 17, 2018
Closed
Closed
@mobileoverlord mobileoverlord merged commit a20f4b0 into master Aug 20, 2018
@mobileoverlord mobileoverlord deleted the distillery-2 branch August 20, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorRigby ConnorRigby ConnorRigby left review comments

@fhunleth fhunleth fhunleth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mobileoverlord @ConnorRigby @fhunleth