Use NERVES_TARGET when building examples #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note about specifying the target via environment variable to example at the end of the page. This tripped me as a new user following along as I ended up building to the wrong target.
The questions are currently a level 1 heading, which is too large given the length of the questions. By changing these to level 3 headings, the visual balance of the page is improved. By using level 3 headings for the questions, level 2 headings are available for use later to group questions once the FAQ becomes large enough. In addition, these future level 2 section headers will render in the navigation tree.
GregMefford
suggested changes
Oct 2, 2016
| ``` | ||
| $ git clone https://github.com/nerves-project/nerves-examples | ||
| $ cd nerves-examples/blinky | ||
| $ mix deps.get && mix firmware | ||
| $ NERVES_TARGET=rpi3 sh -c "mix deps.get && mix firmware" |
There was a problem hiding this comment.
I'm concerned that this little "shell magic" might be intimidating to newcomers. As an alternative, how about NERVES_TARGET=rpi3 mix do deps.get, firmware. This has the additional benefit of introducing the existence of the mix do command, which people may not have encountered yet.
There was a problem hiding this comment.
Sure. I have not encountered the mix do either. I like that much better. Will resubmit tomorrow.
|
Sorry for the big red X in your face! I was playing with the new GitHub Code Review feature and didn't realize the "request changes" option would look so harsh. I think this change is mostly great and I don't mean to give you that gut reaction to your contribution being rejected. 🎈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small doc changes: