Prevent bad vm.args in Nerves firmware #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjcarstens
commented
Jun 30, 2023
jjcarstens
force-pushed
the
elixir-1.15-shell-check
branch
from
94fc6f9
to
ecdfd95
Compare
|
I just realized that we need the opposite check as well since someone might be using Elixir 1.14. I.e., if they specify the Elixir 1.15 way, give them an error. |
|
Good point. Is this also specific to OTP 26? |
|
I don't believe so. I was using the old way with Elixir 1.14 and OTP 26. Unfortunately I feel like things in this area have been changing lately and checking again with Elixir 1.14.5 would be wise. |
jjcarstens
force-pushed
the
elixir-1.15-shell-check
branch
from
ecdfd95
to
9873c5a
Compare
fhunleth
reviewed
Jul 6, 2023
fhunleth
reviewed
Jul 6, 2023
With Elixir 1.15, the way the Elixir IEx shell is started on device has changed and using the old way will break things. This adds a new check during the release (firmware) initialization and stops the firmware build if the old method is still there
This file is required by Nerves, but has gone previously unchecked. Without it, things would be very sad. This adds a check in to prevent firmware being built if there is no vm.args.eex file. In the future, we may want to validate several pieces of it
jjcarstens
force-pushed
the
elixir-1.15-shell-check
branch
from
9873c5a
to
5d16111
Compare
fhunleth
approved these changes
Jul 6, 2023
mnishiguchi
approved these changes
Jul 7, 2023
jjcarstens
added a commit
to nerves-project/nerves_bootstrap
that referenced
this pull request
Jul 7, 2023
jjcarstens
added a commit
to nerves-project/nerves_bootstrap
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Elixir 1.15, the way the Elixir IEx shell is started on device has changed and using the old way will break things.
This adds a new check during the release (firmware) initialization and stops the firmware build if the old method is still there