Set dialyxir and elixir_make to only: :dev #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we open an issue on Elixir about this? Weird we have never ran into this issue before. Also don't we still need |
mobileoverlord
force-pushed
the
fix-deps
branch
from
f2c5480
to
17d222e
Compare
|
I updated this to use [:dev, :test] to fix travis |
|
But apps using this will use |
|
nerves_runtime doesn't need elixir_make or dialyxir in production |
mobileoverlord
force-pushed
the
fix-deps
branch
2 times, most recently
from
2554247
to
78d49c2
Compare
|
If |
|
This is what i was wondering. Does building a dep not build in the env it is configured to run in? |
|
Not to beat a dead horse here, but the line 'compilers: [:elixir_make | Mix.compilers()],' also needs updating if |
…from getting into prod runtime_false does not propigate through hex. All hex packages are built using the production environment, therefore, changing the level of dependency to only dev will remove them from the application spec.
mobileoverlord
force-pushed
the
fix-deps
branch
from
78d49c2
to
6f68955
Compare
|
This is ready now |
fhunleth
approved these changes
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime_false does not propigate through hex. All hex packages are built using the production environment, therefore, changing the level of dependency to only dev will remove them from the application spec.