Angular 1.3.0 RC5 breaks angular-file-upload (RC4 worked fine)

[hoeni]

Hi,

until AngularJS 1.3.0-rc.4 the file upload was working perfect for me. Since AngularJS 1.3.0-rc.5 and in the brand new 1.3.0 release it's broken:

My callbacks for onSuccessItem and onCompleteItem are not called anymore, instead I get a Uncaught TypeError: undefined is not a function message on the console, tracing back to a defaultHttpResponseTransform method in Angular's $HttpProvider.

I'd really love to use this great module with Angular 1.3...

[hoeni]

Seems to be caused by angular/angular.js#2973 / angular/angular.js@7b6c1d0

[caitp]

Please post the entire stack trace so we can see how angular/angular.js@7b6c1d0 is implicated, if it is at all

[caitp]

Better yet a reproduction

[hoeni]

Uncaught TypeError: undefined is not a function angular.js:8569
defaultHttpResponseTransform angular.js:8569
(anonymous function) angular-file-upload.js:1319
forEach angular.js:335
g._transformResponse angular-file-upload.js:1319
c.onload angular-file-upload.js:1319

[caitp]

https://github.com/nervgh/angular-file-upload/blob/master/angular-file-upload.js#L408 is calling the function without headers --- it probably shouldnt be calling transform functions at all, $http should be doing that for you. Unless you can emulate the headers object, don't do it

[hoeni]

@caitp A fix would be simple to make Angular robust against that (probably wrong) behaviour (hoeni/angular.js@40a40b4) but I'm struggling getting the pull request right (never done that before...)

[caitp]

A fix would be to call transformResponse functions with data that they're expected to receive --- even if Angular were robust against this, that wouldn't apply to custom transformers. If you want to call transformResponse, call them with data they're documented to have, or don't call them at all. Period. It's that simple.

[caitp]

This is a bug in angular-file-upload, so that's a relief =)

[hoeni]

@caitp So thanks for your investigation!

[mikhail-eremin]

I had this problem too, after update to angular 1.3 uploader stopped working with same error (
I've tried solution from caitp, and i can approve it works, thanks!
And thanks for great module, using it already for a year

[aureliusm]

So what is the solution? :) Can't seem to understand it..

[caitp]

Pass the header getter function

[mefu]

Can you exactly say what to do for dumbs like me ?

[caitp]

In pseudo code:

Function transformData(response):
    headersFn = parseHeadersAndReturnGetterFn(response.responseHeaders)
    data = response.data
    listOfFns = isList(fns) ? fns : [fns]

    for fn in fns:
        if IsFunction(fn):
            data = fn(data, headersFn)

    return data

[caitp]

so, the code from angular for creating the headersFn is this:

function headersGetter(headers) {
  var headersObj = isObject(headers) ? headers : undefined;

  return function(name) {
    if (!headersObj) headersObj =  parseHeaders(headers);

    if (name) {
      return headersObj[lowercase(name)] || null;
    }

    return headersObj;
  };
}

And the code for parsing responseHeaders is this:

function parseHeaders(headers) {
  var parsed = {}, key, val, i;

  if (!headers) return parsed;

  forEach(headers.split('\n'), function(line) {
    i = line.indexOf(':');
    key = lowercase(trim(line.substr(0, i)));
    val = trim(line.substr(i + 1));

    if (key) {
      parsed[key] = parsed[key] ? parsed[key] + ', ' + val : val;
    }
  });

  return parsed;
}

where headers is the result of xhr.getAllResponseHeaders()

[aureliusm]

Is this fix going to be added in the main version? That would be great..

[nervgh]

Thanks! Fixed.

[hoeni]

Could you bump the depency in bower.json to allow angular 1.3 without warning?