Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added placeholder for console info to fix example error in IE9 #214

Closed
wants to merge 1 commit into from

Conversation

robinwassen
Copy link

The examples are currently throwing error and simply not working in IE9 (probably 8 too) if you have not opened the development tools yet. Probable cause of this is that console.info is undefined until you open up the development tools the first time during the application session.

Fixed this by adding a "shim" for console.info() in the examples, have not tested the fix though since I am too lazy to setup a local server (and github pages for my fork did not work).

@robinwassen
Copy link
Author

Added a screenshot on how it looks in IE9, as you can see on Queue length the whole AngularJS app crashes in the example.

screen shot 2014-08-18 at 14 38 22

@nervgh
Copy link
Owner

nervgh commented Aug 18, 2014

@robinwassen, try press Ctrl+F5

@robinwassen
Copy link
Author

@nervgh CTRL+F5 is force reload - why am I supposed to try that?

My point with this pull request is that the examples would look much better if you did not have to open the dev tools and reload the page for the examples to work. Some people might miss that it is the reason for the examples not working, and instead think that the library doesn't work in IE8 and IE9.

@nervgh
Copy link
Owner

nervgh commented Aug 18, 2014

why am I supposed to try that?

It reloads cached scripts.

console.info() is supported with IE8.
I have IE10 in IE9 mode. This page works fine.

@robinwassen
Copy link
Author

Yes, it is supported, but a bit buggy.

In real IE8 and IE9 console is undefined until you open the development tools, therefore the example script fails if you have not opened the development tools during the active session.

@nervgh
Copy link
Owner

nervgh commented Aug 19, 2014

Thanks. You are right. I added console-sham for old IE browsers in examples.

@nervgh nervgh closed this Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants