fix: Detect target features instead of host features #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code actually detects features on the host, not the target. While this works since we are only compiling on x86_64 for x86_64, it will run into problems when we are trying to cross-compile this crate for other targets, such as wasm. This commit fixes the problem.
zhangsoledad
approved these changes
Sep 10, 2019
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Sep 10, 2019
1575: chore: Bump faster-hex and blake2b-rs versions r=zhangsoledad,u2,yangby-cryptape a=xxuejie Related changes: nervosnetwork/faster-hex#9 nervosnetwork/blake2b-rs#5 Co-authored-by: Xuejie Xiao <xxuejie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code actually detects features on the host, not the
target. While this works since we are only compiling on x86_64 for
x86_64, it will run into problems when we are trying to cross-compile
this crate for other targets, such as wasm. This commit fixes the problem.