feat(core): remove address module #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the address module and expose the addresses via new-introduced key pair module BREAKING CHANGE: remove address module and add key pair module
Codecov Report
@@ Coverage Diff @@
## develop #369 +/- ##
===========================================
- Coverage 99.62% 99.62% -0.01%
===========================================
Files 16 15 -1
Lines 533 527 -6
Branches 147 142 -5
===========================================
- Hits 531 525 -6
Misses 1 1
Partials 1 1
|
Keith-CY
requested review from
shaojunda,
ashchan,
classicalliu and
duanyytop
ashchan
reviewed
Oct 14, 2019
| * genereat address object, who has peroperties like private key, public key, sign method and verify mehtod | ||
| * - value, the address string | ||
| * genereat key pair object, who has peroperties as private key, public key, mainnet address, testnet address, sign method and verify mehtod | ||
| * - mainnetAddress, the address string for the Mainnet |
There was a problem hiding this comment.
It's still mixing address with keys. Key pair should have single responsibility of holding private and public key and provide secp256k1 signing. It has nothing to do with addresses.
Keith-CY
changed the title
…ses from private keys add a method of core.utils.privateKeytoPublicKey add a method of core.utils.privateKeyToAddress BREAKING CHANGE: KeyPair from the core module
Keith-CY
force-pushed
the
refactor-addresses
branch
from
c9e0eb6
to
ca8f790
Compare
duanyytop
reviewed
Oct 14, 2019
| */ | ||
| console.log(myAddressObj.value) | ||
| // console.log(`Public key hash: ${publicKeyHash}`) |
There was a problem hiding this comment.
It's for someone who is unfamiliar with JavaScript.
duanyytop
approved these changes
Oct 14, 2019
shaojunda
reviewed
Oct 14, 2019
| @@ -35,7 +46,7 @@ const bootstrap = async () => { | |||
| const lockScript = { | |||
| hashType: "type", | |||
| codeHash: blockAssemblerCodeHash, | |||
| args: [myAddressObj.publicKeyHash], | |||
| args: [publicKeyHash], | |||
There was a problem hiding this comment.
now args is a Bytes not an array?
There was a problem hiding this comment.
now args is a Bytes not an array?
fixed in 9bcec6b
shaojunda
approved these changes
Oct 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the address module and expose the addresses via new-introduced key pair module
BREAKING CHANGE: remove address module and add key pair module