implement rpc calculate_dao_maximum_withdraw in sdk #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Keith-CY Help to see if it is reasonable. |
Codecov Report
@@ Coverage Diff @@
## develop #578 +/- ##
===========================================
- Coverage 96.28% 95.98% -0.30%
===========================================
Files 49 50 +1
Lines 1533 1571 +38
Branches 301 306 +5
===========================================
+ Hits 1476 1508 +32
- Misses 57 63 +6
|
Keith-CY
reviewed
Feb 28, 2022
packages/ckb-sdk-core/src/index.ts
Outdated
| const withDrawHeader = await this.rpc.getHeader(withdrawBlockHash) | ||
| const withdrawAr = this.#extracDaoData(withDrawHeader.dao).ar | ||
| const { JSBI } = this.utils | ||
| const occupiedCapacity = JSBI.asUintN(64, JSBI.BigInt(10200000000)); |
There was a problem hiding this comment.
The occupied capacity is dynamic according to
10200000000 is just for the default lock in the example.
There was a problem hiding this comment.
According to ckb-explorer, the occupied capacity is determined by withdraw cell, when the withdrawal doesn't occur, we can assume the cell won't change and use deposit cell instead of withdraw cell.
Keith-CY
reviewed
Feb 28, 2022
|
With this set of parameters I've got a result |
|
|
Keith-CY
reviewed
Mar 2, 2022
Keith-CY
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.