chore: Upgrade ckb related deps for latest version #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuJiandong
approved these changes
Jul 6, 2023
| @@ -32,14 +33,16 @@ fn test_multisig_script_hash() { | |||
| let keys = generate_keys(3); | |||
| let multi_sign_script = gen_multi_sign_script(&keys, 2, 0); | |||
| let args = blake160(&multi_sign_script); | |||
| let lock_script = gen_multi_sign_lock_script(args.clone()); | |||
There was a problem hiding this comment.
It is weird: this is only used in assertion. We use a function like below:
pub fn assert_script_error(err: Error, err_code: i8) {
let error_string = err.to_string();
assert!(
error_string.contains(format!("error code {}", err_code).as_str()),
"error_string: {}, expected_error_code: {}",
error_string,
err_code
);
}There was a problem hiding this comment.
Yeah I was mainly on the smallest change to get the tests back working(let's just say that this repo has long pre-dated all the testing tools we build), while also testing full equalness for the error object. Personally I think either way works, I don't have a preference.
zhangsoledad
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.