Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade bytes to 1.x #145

Merged
merged 1 commit into from
Apr 28, 2021
Merged

chore: upgrade bytes to 1.x #145

merged 1 commit into from
Apr 28, 2021

Conversation

driftluo
Copy link
Contributor

I am upgrading tokio/bytes of ckb to 1.x, ckb-vm should be upgraded accordingly, including the current 0.19.x

Do I need another PR for the release branch?

@mohanson
Copy link
Collaborator

I will cherry-pick this PR to the release branch to ensure that the changes to develop and release branches are consistent, so you don’t need to post another PR.

Copy link
Collaborator

@mohanson mohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanson
Copy link
Collaborator

@xxuejie request for a like

@mohanson mohanson merged commit 80a7148 into develop Apr 28, 2021
@driftluo driftluo deleted the upgrade-bytes branch April 28, 2021 10:16
mohanson pushed a commit to mohanson/ckb-vm that referenced this pull request May 6, 2021
xxuejie added a commit that referenced this pull request May 7, 2021
Cherry pick #145 and bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants