Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dynamic setting of memory #304

Merged
merged 36 commits into from
Nov 23, 2022
Merged

Support dynamic setting of memory #304

merged 36 commits into from
Nov 23, 2022

Conversation

joii2020
Copy link
Contributor

@joii2020 joii2020 commented Nov 4, 2022

Support dynamic setting of memory.
completed:interpreter, asm_x64
todo: asm_aarch64

XuJiandong
XuJiandong requested changes Nov 10, 2022
View reviewed changes
definitions/src/asm.rs Show resolved Hide resolved
examples/ckb-vm-runner.rs Outdated Show resolved Hide resolved
@joii2020
In int mode, support dynamic setting of memory
820ea27
@joii2020
Formatting
7d80df4
@joii2020
Assert that memory % RISCV_PAGESIZE == 0
2fdd522
@joii2020
Modify the member variable name peak_memory_usage to memory_size
f54e9fa
@joii2020
Rename: set_peak_memory_usage to set_memory_size
ed861ae
@joii2020
Modify the initialization parameters of AsmCoreMachine to allow suppo…
f49eecc 
…rt for setting memory size
@joii2020
Modify the assembly code so that it can support setting the memory size
50fc304
@joii2020
Modify the interface for the interpreter to set the memory size
75893ff
@joii2020
Arm support dynamic memory
b391d2a
@joii2020
Optimized Arm caching of memory pointer offsets
592b579
@joii2020
Format generate_asm_constants.rs
280cbb7
@joii2020
Update CI to support dynamic memory
a689a8f
@joii2020
Add a comment to AsmCoreMachine
4847540
@joii2020
Optimize the code of ckb-vm-runner
5fadd90
@joii2020
FlatMemory and WXorXMemory support dynamic memory
e1946a2
@joii2020
Add test cases for dynamic memory
49190b2
@joii2020
Test memory overflow
95691f0
@joii2020
Test overflow code into testcase
708104b
@joii2020
Optimize the test case for memory overflow
1e2f428
@joii2020
Fix asm conflicts after rebase
d847b58
@mohanson mohanson changed the title [WIP] Support dynamic setting of memory Support dynamic setting of memory Nov 22, 2022
mohanson
mohanson previously approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@mohanson mohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanson mohanson merged commit 679de4b into nervosnetwork:develop Nov 23, 2022
@joii2020 joii2020 deleted the dev_mem1 branch March 30, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuJiandong XuJiandong XuJiandong requested changes

@mohanson mohanson mohanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joii2020 @XuJiandong @mohanson