Use correct memory pages and size #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's better adding more failing cases (out of memory) for smaller memory (e.g. 1M, 0.5M). |
xxuejie
reviewed
Jul 14, 2023
xxuejie
reviewed
Jul 14, 2023
xxuejie
approved these changes
Jul 14, 2023
XuJiandong
approved these changes
Jul 14, 2023
mohanson
added a commit
to libraries/ckb-vm
that referenced
this pull request
Jul 14, 2023
mohanson
added a commit
to libraries/ckb-vm
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the memory of vm to other than 4M, memory_size and memory_page should be consistent with the real memory size.