chore: panic if the database is corrupted

db/src/db.rs

@@ -138,7 +138,7 @@ impl RocksDB {
                         See https://github.com/facebook/rocksdb/wiki/RocksDB-Repairer for detail",
                         err_str
                     );
-                    Err(internal_error("DB corrupted"))
+                    Err(internal_error(err_str))
                 } else {
                     Err(internal_error(format!(
                         "failed to open the database: {}",

db/src/lib.rs

@@ -28,5 +28,10 @@ pub use rocksdb::{
 pub type Result<T> = result::Result<T, Error>;
 
 fn internal_error<S: fmt::Display>(reason: S) -> Error {
-    InternalErrorKind::Database.other(reason).into()
+    let message = reason.to_string();
+    if message.starts_with("Corruption:") {
+        InternalErrorKind::Database.other(message).into()
+    } else {
+        InternalErrorKind::DataCorrupted.other(message).into()
+    }
 }

sync/src/utils.rs

@@ -78,13 +78,22 @@ fn item_id<Message: Entity>(protocol_id: ProtocolId, message: &Message) -> u32 {
 }
 
 /// return whether the error's kind is `InternalErrorKind::Database`
+///
+/// ### Panic
+///
+/// Panic if the error kind is `InternalErrorKind::DataCorrupted`.
+/// If the database is corrupted, panic is better than handle it silently.
 pub(crate) fn is_internal_db_error(error: &CKBError) -> bool {
     if error.kind() == ErrorKind::Internal {
-        return error
+        let error_kind = error
             .downcast_ref::<InternalError>()
             .expect("error kind checked")
-            .kind()
-            == InternalErrorKind::Database;
+            .kind();
+        if error_kind == InternalErrorKind::DataCorrupted {
+            panic!("{}", error)
+        } else {
+            return error_kind == InternalErrorKind::Database;
+        }
     }
     false
 }