Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dummy pow time configurable #389

Closed
u2 opened this issue Apr 3, 2019 · 2 comments
Closed

Make dummy pow time configurable #389

u2 opened this issue Apr 3, 2019 · 2 comments
Labels
good first issue Good for newcomers s:available Status: This issue is available for implementation. t:enhancement Type: Feature, refactoring.

Comments

@u2
Copy link
Contributor

u2 commented Apr 3, 2019

https://github.com/nervosnetwork/ckb/blob/develop/pow/src/dummy.rs#L29

Adjust dummy pow time to a smaller value for facilitating test or add some config.
@quake
Copy link
Member

quake commented Apr 3, 2019

We may change it to config value.

@doitian doitian changed the title Adjust dummy pow time Make dummy pow time configurable Apr 10, 2019
@doitian doitian added good first issue Good for newcomers m:consensus s:available Status: This issue is available for implementation. t:enhancement Type: Feature, refactoring. labels Apr 10, 2019
@doitian doitian added this to the backlog milestone Apr 12, 2019
@doitian doitian added the 500 label Apr 14, 2019
@yangby-cryptape yangby-cryptape mentioned this issue Apr 18, 2019
Merged
doitian added a commit that referenced this issue Apr 19, 2019
@doitian
Merge pull request #501 from yangby-cryptape/feat-dummy-mode
e33d7e3 
feat: add parameters to control the block generation rate in dummy mode

When I do tests in my laptop, the speed of product block is too slow.

Ref: #389
@doitian
Copy link
Member

doitian commented Apr 19, 2019

#501

@doitian doitian closed this as completed Apr 19, 2019
@doitian doitian modified the milestones: backlog, sprint/0.10.0 Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers s:available Status: This issue is available for implementation. t:enhancement Type: Feature, refactoring.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@quake @doitian @u2