Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add outputs_validator to send_transaction rpc #1879

Merged
merged 3 commits into from
Jan 17, 2020
Merged

feat: add outputs_validator to send_transaction rpc #1879

merged 3 commits into from
Jan 17, 2020

Conversation

quake
Copy link
Member

@quake quake commented Dec 15, 2019

resolve #1866

@quake quake requested a review from a team December 15, 2019 06:26
@doitian doitian added this to 👀 Awaiting review in CKB - Pull Requests Dec 16, 2019
TheWaWaR
TheWaWaR previously approved these changes Dec 16, 2019
View reviewed changes
CKB - Pull Requests automation moved this from 👀 Awaiting review to ✅ Reviewer approved Dec 31, 2019
doitian
doitian previously approved these changes Dec 31, 2019
View reviewed changes
@TheWaWaR
Copy link
Contributor

TheWaWaR commented Jan 2, 2020

Rebase required.

@quake quake dismissed stale reviews from doitian and TheWaWaR via f5e3be6 January 3, 2020 03:13
@quake quake force-pushed the quake/rpc-send-transaction-output-validator branch from a095565 to f5e3be6 Compare January 3, 2020 03:13
CKB - Pull Requests automation moved this from ✅ Reviewer approved to 👀 Awaiting review Jan 3, 2020
@quake
Copy link
Member Author

quake commented Jan 3, 2020

Rebase required.

rebased, please review again

doitian
doitian previously approved these changes Jan 3, 2020
View reviewed changes
keroro520
keroro520 suggested changes Jan 4, 2020
View reviewed changes
rpc/README.md Show resolved Hide resolved
rpc/src/module/pool.rs Show resolved Hide resolved
@quake quake force-pushed the quake/rpc-send-transaction-output-validator branch from f5e3be6 to 276651d Compare January 16, 2020 09:40
CKB - Pull Requests automation moved this from 👀 Awaiting review to ✅ Reviewer approved Jan 17, 2020
@doitian
Copy link
Member

doitian commented Jan 17, 2020

bors r=doitian,keroro520

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Jan 17, 2020
bors bot added a commit that referenced this pull request Jan 17, 2020
@bors @quake
Merge #1879
44b0d35 
1879:  feat: add `outputs_validator` to `send_transaction` rpc r=doitian,keroro520 a=quake

resolve #1866 

Co-authored-by: quake wang <quake.wang@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 17, 2020

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 276651d into develop Jan 17, 2020
CKB - Pull Requests automation moved this from ✅ Reviewer approved to Done Jan 17, 2020
@bors bors bot deleted the quake/rpc-send-transaction-output-validator branch January 17, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@keroro520 keroro520 keroro520 approved these changes

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

Assignees
No one assigned
Labels
s:ready-to-merge Status: Waiting to be merged.
Projects
CKB - Pull Requests
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an optional outputs_validator parameter to send_transaction rpc
4 participants
@quake @TheWaWaR @doitian @keroro520