Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace rocksdb wrapper #1956

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

zhangsoledad
Copy link
Member

Issue

Cargo fetch the git repository is unbearably slow

Proposed Changes

Replace it with published crate.
explicitly features = ["snappy"] for backward compatibility.

@zhangsoledad zhangsoledad requested review from a team and xxuejie March 5, 2020 07:07
quake
quake previously approved these changes Mar 5, 2020
@zhangsoledad
Copy link
Member Author

bors r+

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Mar 6, 2020
bors bot added a commit that referenced this pull request Mar 6, 2020
1956: feat: replace rocksdb wrapper r=zhangsoledad a=zhangsoledad

## Issue
Cargo fetch the git repository is unbearably slow

## Proposed Changes
Replace it with published crate.
explicitly `features = ["snappy"]` for backward compatibility.

Co-authored-by: zhangsoledad <787953403@qq.com>
@bors
Copy link
Contributor

bors bot commented Mar 6, 2020

Build failed

  • continuous-integration/travis-ci/push

@quake
Copy link
Member

quake commented Mar 6, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 6, 2020

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit e76cbe0 into nervosnetwork:develop Mar 6, 2020
@zhangsoledad zhangsoledad deleted the ckb_rocksdb branch March 6, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:ready-to-merge Status: Waiting to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants