Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade tokio for tx-pool #2043

Merged
merged 1 commit into from
May 29, 2020
Merged

refactor: upgrade tokio for tx-pool #2043

merged 1 commit into from
May 29, 2020

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Apr 26, 2020 •
edited
Loading

Proposal Changes

  • bump tokio 0.2
  • refactor tx-pool with async/await

@zhangsoledad zhangsoledad requested review from a team and quake April 26, 2020 14:46
@zhangsoledad
Copy link
Member Author

benchmark

@nervos-bot-user
Copy link
Collaborator

Benchmark Result

  • TPS: 364.07
  • Samples Count: 51
  • CKB Version: 3aedeab
  • Instance Type: c5.xlarge
  • Instances Count: 3
  • Bench Type: 2in2out
  • CKB Logger Filter: info,ckb=debug

@doitian doitian added this to 👀 Awaiting review in CKB - Pull Requests Apr 27, 2020
@zhangsoledad
Copy link
Member Author

benchmark

@nervos-bot-user
Copy link
Collaborator

Benchmark Result

  • TPS: 355.13
  • Samples Count: 51
  • CKB Version: 3aedeab
  • Instance Type: c5.xlarge
  • Instances Count: 3
  • Bench Type: 2in2out
  • CKB Logger Filter: info,ckb=debug

@doitian doitian requested a review from driftluo April 27, 2020 03:58
@zhangsoledad
Copy link
Member Author

benchmark

@nervos-bot-user
Copy link
Collaborator

Benchmark Result

  • TPS: 365.26
  • Samples Count: 50
  • CKB Version: d099f4e
  • Instance Type: c5.xlarge
  • Instances Count: 3
  • Bench Type: 2in2out
  • CKB Logger Filter: info,ckb=debug

quake
quake previously approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@quake quake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase to resolve conflicting

driftluo
driftluo previously approved these changes May 22, 2020
View reviewed changes
quake
quake previously approved these changes May 22, 2020
View reviewed changes
CKB - Pull Requests automation moved this from 👀 Awaiting review to ✅ Reviewer approved May 22, 2020
@quake
Copy link
Member

quake commented May 22, 2020

bors r=quake,driftluo

bors bot added a commit that referenced this pull request May 22, 2020
@bors @zhangsoledad
Merge #2043
87064b4 
2043: refactor: upgrade tokio for tx-pool r=quake,driftluo a=zhangsoledad

### Proposal Changes
* bump tokio 0.2
* refactor tx-pool with async/await

Co-authored-by: zhangsoledad <787953403@qq.com>
@bors
Copy link
Contributor

bors bot commented May 22, 2020

Build failed:

@zhangsoledad
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request May 22, 2020
@bors @zhangsoledad
Merge #2043
d7e803f 
2043: refactor: upgrade tokio for tx-pool r=quake,driftluo a=zhangsoledad

### Proposal Changes
* bump tokio 0.2
* refactor tx-pool with async/await

Co-authored-by: zhangsoledad <787953403@qq.com>
@bors
Copy link
Contributor

bors bot commented May 22, 2020

Build failed:

  • continuous-integration/travis-ci/push

@zhangsoledad zhangsoledad dismissed stale reviews from quake and driftluo via 42f7218 May 22, 2020 11:11
CKB - Pull Requests automation moved this from ✅ Reviewer approved to 👀 Awaiting review May 22, 2020
@zhangsoledad
Copy link
Member Author

benchmark

@nervos-bot-user
Copy link
Collaborator

Benchmark Result

  • TPS: 351.84
  • Samples Count: 50
  • CKB Version: 42f7218
  • Instance Type: c5.xlarge
  • Instances Count: 3
  • Bench Type: 2in2out
  • CKB Logger Filter: info,ckb=debug

CKB - Pull Requests automation moved this from 👀 Awaiting review to ✅ Reviewer approved May 29, 2020
@quake
Copy link
Member

quake commented May 29, 2020

bors r=quake,driftluo

@bors
Copy link
Contributor

bors bot commented May 29, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 0b96ed9 into nervosnetwork:develop May 29, 2020
CKB - Pull Requests automation moved this from ✅ Reviewer approved to Done May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@driftluo driftluo driftluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CKB - Pull Requests
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhangsoledad @nervos-bot-user @quake @driftluo