feat(rpc): Improve error messages from send transaction RPC

[doitian]

This PR adds extra information in transaction verification errors, such as:

• Which input, cell_dep, header_dep or output causes the error
• If there's a limit, what's the value of the limit.

There're also ambiguous error messages. For example, the pool has its own cycles limit on a single transaction, which is configurable in the config file. The block also as a limit on all the transactions in the block. Apparently, for a single transaction, the cycles should not exceed the block limit. This PR also avoids using the same error for different reasons.

[k]

Looking forward to this. It was hard to decipher the error message:

2020-05-25 11:58:49.902 -07:00 GlobalRuntime-0 INFO ckb-script  Error validating script group Byte32(0x2b0f12e62a438b5cccc51a0680bb7c142436e1bdf4c4b9932e47dbed9b366419) of transaction Byte32(0x19a88b96de6bc874a2748e7192c99aabff0a3ac4b9423d6b70edc92a7c4f57bd): Script(ValidationFailure(-31))

I was looking for the error code -31 in this repository but didn't realize it was from a lock script. Would be good to know what stage the validation is on, whether its a lock script, type script, or other validation failure. Especially since technically type scripts could also use the error code -31. I suppose one could look up the script with the Byte32(0x2b0f12e62a438b5cccc51a0680bb7c142436e1bdf4c4b9932e47dbed9b366419) but the lock vs type script is a helpful heuristic.

[doitian]

Looking forward to this. It was hard to decipher the error message:

2020-05-25 11:58:49.902 -07:00 GlobalRuntime-0 INFO ckb-script  Error validating script group Byte32(0x2b0f12e62a438b5cccc51a0680bb7c142436e1bdf4c4b9932e47dbed9b366419) of transaction Byte32(0x19a88b96de6bc874a2748e7192c99aabff0a3ac4b9423d6b70edc92a7c4f57bd): Script(ValidationFailure(-31))

I was looking for the error code -31 in this repository but didn't realize it was from a lock script. Would be good to know what stage the validation is on, whether its a lock script, type script, or other validation failure. Especially since technically type scripts could also use the error code -31. I suppose one could look up the script with the Byte32(0x2b0f12e62a438b5cccc51a0680bb7c142436e1bdf4c4b9932e47dbed9b366419) but the lock vs type script is a helpful heuristic.

Roger that

[doitian]

Looking forward to this. It was hard to decipher the error message:

2020-05-25 11:58:49.902 -07:00 GlobalRuntime-0 INFO ckb-script  Error validating script group Byte32(0x2b0f12e62a438b5cccc51a0680bb7c142436e1bdf4c4b9932e47dbed9b366419) of transaction Byte32(0x19a88b96de6bc874a2748e7192c99aabff0a3ac4b9423d6b70edc92a7c4f57bd): Script(ValidationFailure(-31))

I was looking for the error code -31 in this repository but didn't realize it was from a lock script. Would be good to know what stage the validation is on, whether its a lock script, type script, or other validation failure. Especially since technically type scripts could also use the error code -31. I suppose one could look up the script with the Byte32(0x2b0f12e62a438b5cccc51a0680bb7c142436e1bdf4c4b9932e47dbed9b366419) but the lock vs type script is a helpful heuristic.

Fixed in #2164

[doitian]

Rebased since it does not depend on #2038

[doitian]

Fixed up 883dcf9 because of the clippy error

error: redundant field names in struct initialization
   --> verification/src/transaction_verifier.rs:398:21
    |
398 |                     index: index,
    |                     ^^^^^^^^^^^^ help: replace it with: `index`
    |
    = note: `-D clippy::redundant-field-names` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

[doitian]

bors r=quake,zhangsoledad,yangby-cryptape

[zhangsoledad]

bors r=quake,zhangsoledad,yangby-cryptape

[bors]

Build succeeded:

• continuous-integration/travis-ci/push