fix: Fix collaboration issues between two protocol #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driftluo
force-pushed
the
fix-sync-relayer-collaboration
branch
2 times, most recently
from
dcc4ce8
to
45689f3
Compare
doitian
previously approved these changes
May 14, 2020
driftluo
force-pushed
the
fix-sync-relayer-collaboration
branch
from
45689f3
to
3775288
Compare
| &self.chain, | ||
| &self.shared.active_chain().tip_header().hash(), | ||
| ) | ||
| }), |
There was a problem hiding this comment.
https://github.com/nervosnetwork/p2p/blob/master/src/protocol_handle_stream.rs#L197
p2p already issuing notify handle as a blocking call, so I think tokio::task::block_in_place( is unnecessary, also the TX_PROPOSAL_TOKEN handle.
There was a problem hiding this comment.
https://github.com/nervosnetwork/ckb/blob/develop/ckb-bin/src/subcommand/run.rs#L91
For performance and control, p2p blocking is disabled at the ckb level and it is controlled by itself
quake
approved these changes
May 18, 2020
doitian
approved these changes
May 19, 2020
CKB - Pull Requests
automation
moved this from 👀 Awaiting review
to ✅ Reviewer approved
May 19, 2020
|
@zhangsoledad Do you still have any concern about this PR? |
|
bors r=quake,doitian |
|
Build succeeded:
|
doitian
pushed a commit
that referenced
this pull request
May 21, 2020
2075: fix: Fix collaboration issues between two protocol r=quake,doitian a=driftluo relayer and sync have some known problems in the critical zone of switching, which are inherent to the request/response architecture. Previous attempts to fix the problem by allowing duplicate downloads, but this solution results in wasted network resources and slowed sync speed. This typical problem can be solved by the node itself, and the current PR gives a temporary solution to try to check the orphan pool with a very low-frequency timer. Co-authored-by: driftluo <driftluo@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relayer and sync have some known problems in the critical zone of switching, which are inherent to the request/response architecture.
Previous attempts to fix the problem by allowing duplicate downloads, but this solution results in wasted network resources and slowed sync speed.
This typical problem can be solved by the node itself, and the current PR gives a temporary solution to try to check the orphan pool with a very low-frequency timer.