Add fail-points to test robustness #2090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
requested changes
Jun 12, 2020
@xxuejie should we start to add docs to new docs site instead? |
keroro520
requested review from
yangby-cryptape,
zhangsoledad and
a team
as code owners
Explicitly pointing out the protocol whenever messages sent is better.
doitian
approved these changes
Jun 19, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
doitian
added
pinned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail-pointsinckb.toml.sync/src/utils.rsto wrap most of the operations of sending messages.0.1%probability of network messages lost, another is normal. The former takes170minutes and the latter takes120minutes to synchronize to the TIP.