Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove fee estimator #2126

Merged

Conversation

zhangsoledad
Copy link
Member

This estimate_fee_rate RPC is experimental, due to availability and performance issues, we decide to remove it.

@zhangsoledad zhangsoledad requested review from a team and xxuejie June 16, 2020 14:26
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/remove_fee_estimator branch from bc13bb7 to 317f8d1 Compare June 16, 2020 17:38
@doitian
Copy link
Member

doitian commented Jun 17, 2020

bors r=quake,driftluo

@bors
Copy link
Contributor

bors bot commented Jun 17, 2020

Build succeeded:

@bors bors bot merged commit 485ad3d into nervosnetwork:develop Jun 17, 2020
@zhangsoledad zhangsoledad deleted the zhangsoledad/remove_fee_estimator branch June 17, 2020 07:05
@driftluo driftluo mentioned this pull request Aug 11, 2020
bors bot added a commit that referenced this pull request Aug 28, 2021
2986: chore: remove several useless files r=quake,zhangsoledad a=yangby-cryptape

### What problem does this PR solve?

Remove several useless files:

- A python script to fix code coverage with `cargo tarpaulin`.

  Deprecated since #2940.

- The crate `ckb-fee-estimator`.

  Deprecated since #2365, which is bases on #2126.

### Check List

Tests

- No code (skip ci)

### Release note

```release-note
None: Exclude this PR from the release note.
```



Co-authored-by: Boyu Yang <yangby@cryptape.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants